refactor: remove local relay functionality#533
Merged
Conversation
…ding Removes LocalRelayConfig, LocalRelayWritePolicy, the LOCAL value in RelaySetType, and isLocalRelayUrl from RelayConfig.kt. Strips local relay state, forwarding paths, lifecycle pause/resume, and the own-notes OutboxRouter branch from the relay layer.
Removes the local_relay SharedPrefs entry, KeyRepository's localRelayFlow / save/get/load helpers, and RelayViewModel's local-relay state and update methods. StartupCoordinator no longer wires the relay pool to localRelayFlow. reloadPrefs clears the orphaned local_relay key on account switch.
RelayScreen drops the LOCAL tab and its LocalRelayTab composable. FeedScreen's RelayPickerDialog no longer surfaces a "My Local Relay" row, and its localRelayUrl parameter is removed.
Drops all local_relay_* keys from English and 10 translated locales. Sets cleartextTrafficPermitted=false in the network security config now that ws:// is no longer needed for any relay URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LocalRelayConfig,LocalRelayWritePolicy, theLOCALvalue inRelaySetType,isLocalRelayUrl, runtime forwarding inRelayPool, lifecycle pause/resume, theOutboxRouterown-notes branch, and thelocal_relaySharedPrefs key.LocalRelayTabcomposable fromRelayScreen, and the "My Local Relay" row fromFeedScreen's relay picker.local_relay_*string resources across English and 10 translated locales.network_security_config.xmltocleartextTrafficPermitted="false"now that no relay URL ever needsws://.KeyRepository.reloadPrefsclears the orphanedlocal_relaySharedPrefs entry on account switch so existing installs don't carry it forever.Test plan
./gradlew assembleDebugbuilds cleanlocal_relaypref → app starts normally and the orphaned key is cleared on account switch