feat: apply web of trust filter to thread replies#583
Merged
Conversation
The WoT filter was already silently dropping events at EventRepository ingestion and in NotificationRepository, but thread replies bypassed both paths — ThreadViewModel keeps its own threadEvents map seeded via cacheEvent() and getCachedThreadEvents(), neither of which checks WoT. Apply isWotFiltered in rebuildTree() alongside the existing block / mute / spam filters. The root note is always shown (user explicitly navigated to it); replies from authors outside the qualified network are silently dropped, matching how WoT behaves in the feed and notifications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EventRepository.addEventand insideNotificationRepository, but thread replies bypassed both paths —ThreadViewModelkeeps its ownthreadEventsmap seeded viacacheEvent()andgetCachedThreadEvents(), neither of which checks WoTisWotFilteredinsiderebuildTree()alongside the existing block / mute / spam filtersisWotFilteredchanged fromprivateto package-default soThreadViewModelcan reuse the same logic instead of duplicating itTest plan
isNetworkReadyreturns false) — falls open, no regressionisWotFiltered)