Fix notifications not refreshing on app resume#83
Merged
Conversation
subscribeDmsAndNotifications() was only called on force reconnects (pause >= 30s), so returning from a short pause while on the notifications screen left stale data. Move the call outside the force-only block so it runs on every reconnect, matching feed behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subscribeDmsAndNotifications()was only called on force reconnects (pause >= 30s), so returning from a short pause while on the notifications screen showed stale dataif (force)block so notifications and DMs re-subscribe on every app resume, matching the feed's behaviorTest plan