fix: prevent duplicate zap counting from race conditions#84
Merged
Conversation
EventRepository: wrap countedZapIds get-or-create in synchronized block to prevent concurrent threads (e.g. thread-reactions + notif collectors) from creating separate dedup sets for the same target event. NotificationRepository: add secondary event ID dedup in mergeZap to guard against LRU eviction in seenEvents allowing the same 9735 event to be re-processed on periodic refresh cycles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
countedZapIdsget-or-create in asynchronizedblock to prevent concurrent collectors (e.g. thread-reactions + notif) from creating separate dedup sets for the same target, causing zaps to be double-countedmergeZapto guard against LRU eviction inseenEventsallowing the same 9735 event to be re-processed on periodic refresh cycles — unlikemergeReactionwhich already has inner pubkey dedup,mergeZapwas blindly appendingTest plan