Skip to content

Fix flaky e2e Tribute popup selection in CI#210

Merged
bartekplus merged 2 commits intomasterfrom
codex/fix-e2e-tribute-menu-flake
Feb 24, 2026
Merged

Fix flaky e2e Tribute popup selection in CI#210
bartekplus merged 2 commits intomasterfrom
codex/fix-e2e-tribute-menu-flake

Conversation

@bartekplus
Copy link
Owner

Summary

  • make popup suggestion reads use the active focused input's tribute menu first, then visible menu fallback
  • avoid brittle global .tribute-container li:first-child lookups that can target stale menus in CI
  • dispatch mousedown/mouseup/click for suggestion selection to match Tribute menu handling
  • keep deterministic post-click wait for inserted text

Validation

  • CI=true npm run test:e2e (pass)
  • CI=true npx jest --config=jest-e2e.config.ts tests/e2e/puppeteer-extension.test.ts -t 'Prediction popup appears in #test-contenteditable when typing and prediction is inserted on TAB' --runInBand (12/12 passes)

@bartekplus bartekplus self-assigned this Feb 24, 2026
@bartekplus bartekplus merged commit 4445ad3 into master Feb 24, 2026
4 checks passed
@bartekplus bartekplus deleted the codex/fix-e2e-tribute-menu-flake branch February 24, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant