Skip to content

Fix Rentry CodeMirror input routing#306

Merged
bartekplus merged 16 commits intomasterfrom
codex/rentry-input-root-cause
Mar 12, 2026
Merged

Fix Rentry CodeMirror input routing#306
bartekplus merged 16 commits intomasterfrom
codex/rentry-input-root-cause

Conversation

@bartekplus
Copy link
Owner

Summary

  • route CodeMirror-backed editor input through the hidden backing textarea while keeping the visible contenteditable surface for focus and edits
  • remove the CodeMirror-specific replacement branch and keep scoped contenteditable edits on the generic DOM path
  • keep the new observability coverage and add regression tests for backing-input discovery and listener wiring

Validation

  • bun run lint
  • bun run format:check
  • bun test tests/TextTargetAdapter.test.ts tests/SuggestionLifecycleController.test.ts tests/ContentEditableAdapter.test.ts tests/SuggestionEntrySession.test.ts tests/content_script.behavior.test.ts tests/SuggestionManagerRuntime.test.ts tests/SuggestionManager.test.ts
  • bun tsc --noEmit

@bartekplus
Copy link
Owner Author

@claude review!

@bartekplus bartekplus merged commit 975f8cc into master Mar 12, 2026
8 checks passed
@bartekplus bartekplus deleted the codex/rentry-input-root-cause branch March 12, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant