fix: prevent inline suggestion from disappearing on heavy DOM sites#344
Merged
bartekplus merged 2 commits intomasterfrom Mar 23, 2026
Merged
Conversation
…DOM rebuilds Sites like Google Translate replace textarea elements and rebuild large portions of the DOM on every keystroke (500+ mutations). This caused the inline ghost text to vanish through three independent mechanisms: 1. Transient blur: the old textarea fires blur when replaced, even though focus immediately moves to the new textarea. Fixed by deferring blur dismiss to a microtask and rechecking focus state. 2. Cross-entry cleanup: stale entry disposal called a global removeAll() that destroyed the active entry's ghost div. Fixed by scoping ghost elements with a per-entry data attribute and using clearForEntry(). 3. External DOM removal: the DOM rebuild physically removed the ghost div from the document. Fixed by observing the ghost with a MutationObserver and auto-re-rendering when it's removed externally. Also fixes Tab consuming the keypress after suggestions were dismissed by requiring active suggestions before the request-and-auto-accept path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- InlineSuggestionPresenter: test clearForEntry scoping, clearAll global behavior, and auto-re-render after external DOM removal - InlineSuggestionView: test removeForEntry preserves other entries' ghosts - SuggestionKeyboardHandler: test Tab passes through when suggestions are dismissed (empty suggestions array) - Update existing tests for deferred blur dismiss (await microtask) and entry-scoped cleanup (removeForEntry instead of removeAll) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bartekplus
deleted the
fix/inline-suggestion-disappearing-on-heavy-dom-sites
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code