fix: align inline suggestion with vertically centered input text#347
Merged
bartekplus merged 2 commits intomasterfrom Mar 24, 2026
Merged
Conversation
The caret measurement mirror <div> top-aligns text after padding, but <input> elements vertically center their text. This caused inline suggestions to appear shifted up on inputs with extra height (e.g. GitHub branch selector). Account for the centering offset when the target is an <input>. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Verifies that getCaretRect shifts the caret down for tall <input> elements (which vertically center text) and leaves <textarea> behavior unchanged. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<input>elements vertically center their text, but the mirror<div>used for caret measurement top-aligns it after padding(contentHeight - lineBoxHeight) / 2when the target is an<input>Test plan
🤖 Generated with Claude Code