feat: promote inline suggestion to general settings#348
Merged
bartekplus merged 2 commits intomasterfrom Mar 24, 2026
Merged
Conversation
Move inline suggestion out of the "Behavior After Completion" group into the "General" options group. Remove experimental language from all i18n descriptions and expand them to explain the feature and its locked settings. When inline suggestion is enabled, lock "Accept with Tab key", "Prefix-only mode", and "Number of predictions" via a new setDisabled() API on BaseControl. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… loadFromStorage The initial applyInlineSuggestionLocks() call now reads the persisted value directly from the store instead of the control's DOM state, which may not yet reflect the stored value due to async loadFromStorage(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setDisabled()API toBaseControlfor proper control locking (withis-disabledCSS class on root)Test plan
bun run checkpasses (lint, format, typecheck)bun testpasses (1606 tests)🤖 Generated with Claude Code