Skip to content

Showing PDF files by URL - #548

Closed
achatina wants to merge 3 commits into
DImuthuUpe:masterfrom
achatina:master
Closed

Showing PDF files by URL#548
achatina wants to merge 3 commits into
DImuthuUpe:masterfrom
achatina:master

Conversation

@achatina

@achatina achatina commented Mar 9, 2018

Copy link
Copy Markdown

I made a class that helps with showing pdf files from network.
A sample usage also provides in a sample project.
It will help developers to download files without redundant code with your library.

@achatina achatina changed the title Showing PDF files with URL Showing PDF files by URL Mar 9, 2018
@barteksc

barteksc commented Apr 1, 2018

Copy link
Copy Markdown
Collaborator

Thank you for contribution.
The problem is that on every configuration change (eg. orientation change), download process starts again and previous one is not finished - downloading process must be aware of Activity lifecycle.
You also forgot to add ACCESS_NETWORK_STATE and INTERNET permissions, but this is minor issue.

@pierko002 pierko002 mentioned this pull request Aug 3, 2018
@achatina achatina closed this Nov 14, 2018
@imBalasankar

Copy link
Copy Markdown

@achatina Thank you so much for your awesome contribution! Really loved it!!

@achatina

Copy link
Copy Markdown
Author

@imBalasankar Thanks. But it's not complete at all. No time for it. Maybe someone will continue this

@fukemy

fukemy commented Oct 18, 2020

Copy link
Copy Markdown

hello, do y have gradle link to import?

@achatina

Copy link
Copy Markdown
Author

@fukemy hi!
Unfortunately - no. The best solution will be download file by yourself and pass local file into it. It's not very difficult and will not take much time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants