Skip to content

197 i would like to have a wallet capable of signing messages implemented in c#198

Merged
kmroz merged 4 commits intomainfrom
197-i-would-like-to-have-a-wallet-capable-of-signing-messages-implemented-in-c
Aug 25, 2023
Merged

197 i would like to have a wallet capable of signing messages implemented in c#198
kmroz merged 4 commits intomainfrom
197-i-would-like-to-have-a-wallet-capable-of-signing-messages-implemented-in-c

Conversation

@bartossh
Copy link
Copy Markdown
Owner

The signer is capable of signing the message. This includes Signer to:

  • Create a sha256 digest of the message.
  • Precalcule the required signature length (no need to pass a buffer).
  • Sign the digest.
  • Return Signature structure (signature buffer, signature length, digest buffer, digest length).
  • Offer a free method to clean up allocated memory.

@bartossh bartossh added the enhancement New feature or request label Aug 25, 2023
@bartossh bartossh self-assigned this Aug 25, 2023
Copy link
Copy Markdown
Collaborator

@kmroz kmroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... 👍🏻

Had 2 small questions regarding the use of OPENSSL_free()/free().

Comment thread c/client-node/signer/signer.c
Comment thread c/client-node/signer/signer.c
@kmroz kmroz merged commit 2bb4fd7 into main Aug 25, 2023
@kmroz kmroz deleted the 197-i-would-like-to-have-a-wallet-capable-of-signing-messages-implemented-in-c branch August 25, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I would like to have a wallet capable of signing messages implemented in C.

2 participants