Conversation
bartossh
added
enhancement
bartossh
requested review from
dmatusiewicz-consult-red,
kmroz and
kubagruszka
kmroz
approved these changes
Aug 30, 2023
Collaborator
kmroz
left a comment
kmroz
left a comment
There was a problem hiding this comment.
Looks good... and I'm really liking the little test framework!
The only thing that comes to mind is sanity checking the token values (ie. atoi("8080") will return 0, invalid url forms, etc). I think I can cook something up, and dust of my copy of K&R 👍🏻
kmroz
deleted the
208-c-impl-needs-a-config-file-reader-to-read-the-config-before-running-the-client
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C impl needs a config file reader to read the config before running the client.
This is a simple tex file as we are not implementing any other node than the client node and do not need a nested setup.