Conversation
bartossh
added
documentation
bartossh
requested review from
cezary-kujawa-red,
cezarykujawa,
dmatusiewicz-consult-red,
kmroz and
kubagruszka
Owner
Author
|
#240 here we will make block validation work as expected. |
kmroz
approved these changes
Sep 12, 2023
Collaborator
kmroz
left a comment
kmroz
left a comment
There was a problem hiding this comment.
Hefty diff 😄 Overall lgtm.
Just the one question (in teams). I'm also not sure about changing the name of the validator process to "helper". Let's discuss that one later.
Marking as 👍🏻
…igrate-from-web-socket-to-pub-sub
bartossh
deleted the
232-validator-node-central-node-connection-migrate-from-web-socket-to-pub-sub
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nats basic client with test.