Multichain support in mcmcstep module #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed it because it is static and static attributes are a pain to deal with in the multichain implementation, they don't play nicely with vmap. I will remove the other static attributes in the next commits.
In ended up supporting static fields, so deleting Kind and moving around the batch sizes was not necessary, but the current version looks better so whatever.
This commit changes the previous object-oriented multichain support with a more general and lightweight functional implementation based on pytrees.
Gattocrucco
commented
Jan 2, 2026
Collaborator
Author
Gattocrucco
left a comment
Gattocrucco
left a comment
There was a problem hiding this comment.
Changes requested; marked them locally.
This was referenced Jan 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the multichain implementation is completely at the interface level in
mc_gbartwith a big fat vmap over everything. This was convenient to set it up quickly but has the following issues:This PR implements multichain directly at the level of the
mcmcstepmodule.