Conversation
bas080
force-pushed
the
require-schema-in-parse-to-prevent-access-of-undefined-refs
branch
from
714fe17 to
fb07ccf
Compare
This results in a major release because it changes the API. Since we are doing that we can also do some renames and changes to other APIs.
bas080
force-pushed
the
require-schema-in-parse-to-prevent-access-of-undefined-refs
branch
from
fb07ccf to
9d03782
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things to consider are the change of stringify to also take a schema. This is not required as of now. Should that be changed or should we keep the "module" module. There are reasons for and against.
Reasons for:
Reasons against:
Reasons against win. We do not want people throwing away stringify functions or create a new one just to stringify other instrumented values.
We add back the idea of module but let's also carefully consider the naming.