Skip to content

fix error RecursionError in driver pool #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhmdasghari merged 1 commit into from
Jul 22, 2025
Merged

fix error RecursionError in driver pool #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 15 additions & 19 deletions src/basalam/backbone_orm/postgres_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ def __init__(self, config: ConnectionConfig) -> None:
self.__config = config
self.__is_creating_pool: bool = False
self.__pool: Optional[asyncpg.Pool] = None
self.__pool_lock = asyncio.Lock()
self.__acquires: Dict[str, Tuple[PostgresConnection, PoolAcquireContext]] = {}

async def acquire(self, key: Any) -> PostgresConnection:
Expand All @@ -100,26 +101,21 @@ async def release(self, key: Any) -> None:
del self.__acquires[key]

async def pool(self):
if self.__is_creating_pool:
await asyncio.sleep(0.1)
return await self.pool()

if self.__pool is None:
self.__is_creating_pool = True
self.__pool = await asyncpg.create_pool(
min_size=self.__config.pool_min_size,
max_size=self.__config.pool_max_size,
max_inactive_connection_lifetime=self.__config.pool_max_inactive_connection_lifetime,
user=self.__config.user,
password=self.__config.password,
host=self.__config.host,
port=self.__config.port,
database=self.__config.db,
timeout=self.__config.timeout,
server_settings=dict(**self.__config.server_settings),
)
self.__is_creating_pool = False

async with self.__pool_lock:
if self.__pool is None:
self.__pool = await asyncpg.create_pool(
min_size=self.__config.pool_min_size,
max_size=self.__config.pool_max_size,
max_inactive_connection_lifetime=self.__config.pool_max_inactive_connection_lifetime,
user=self.__config.user,
password=self.__config.password,
host=self.__config.host,
port=self.__config.port,
database=self.__config.db,
timeout=self.__config.timeout,
server_settings=dict(**self.__config.server_settings),
)
return self.__pool


Expand Down