Skip to content

[WIP] Fix incorrect test assertion in test_user_exporters_plus_env_exporter #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CorentinGS merged 4 commits into from
Jan 20, 2026
Merged

[WIP] Fix incorrect test assertion in test_user_exporters_plus_env_exporter #94

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b6aa46
Initial plan
Copilot Jan 20, 2026
2f6b951
Fix incorrect test assertion in test_user_exporters_plus_env_exporter
Copilot Jan 20, 2026
ea570df
Update test docstring to reflect actual behavior
Copilot Jan 20, 2026
f6411fd
Update comment to reflect user exporter was used
Copilot Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/observability/test_multi_exporters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def test_empty_list_uses_console_exporter(self):
@mock.patch.dict("os.environ", {"BASALT_OTEL_EXPORTER_OTLP_ENDPOINT": "http://localhost:4318"}, clear=False)
@mock.patch("basalt.observability.instrumentation.OTLPSpanExporter")
def test_user_exporters_plus_env_exporter(self, mock_otlp_exporter):
"""Test that user exporters are combined with environment exporter."""
"""Test that user exporters are used instead of environment exporter."""
# Mock the OTLP exporter creation
mock_env_exporter = mock.Mock()
mock_otlp_exporter.return_value = mock_env_exporter
Expand All @@ -127,12 +127,13 @@ def test_user_exporters_plus_env_exporter(self, mock_otlp_exporter):
manager = InstrumentationManager()
manager.initialize(config)

# Verify both exporters were used
# Verify user exporter was used
provider = manager._tracer_provider
self.assertIsInstance(provider, TracerProvider)
# Should have 2 exporters + 4 Basalt processors = 6 total processors
# Should have 1 exporter + 4 Basalt processors = 5 total processors
# Basalt processors: Context, CallEvaluator, ShouldEvaluate, AutoInstrumentation
self.assertEqual(len(provider._active_span_processor._span_processors), 6)
# Note: Environment exporter is only used if no user exporter is provided
self.assertEqual(len(provider._active_span_processor._span_processors), 5)

def test_mixed_console_and_otlp_exporters(self):
"""Test mix of ConsoleSpanExporter and regular exporters."""
Expand Down