fix: propagate pay dataSuffix to sendCalls attribution#255
Merged
spencerstock merged 1 commit intomasterfrom Mar 20, 2026
Merged
fix: propagate pay dataSuffix to sendCalls attribution#255spencerstock merged 1 commit intomasterfrom
spencerstock merged 1 commit intomasterfrom
Conversation
Ensure pay() validates dataSuffix and passes it through translatePaymentToSendCalls so requests include capabilities.attribution.suffix on the actual sendCalls payload. Made-with: Cursor
Collaborator
✅ Heimdall Review Status
|
fan-zhang-sv
approved these changes
Mar 18, 2026
stephancill
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dataSuffixthroughpay()intotranslatePaymentToSendCalls(...)so wallet payloads includecapabilities.attribution.suffixdataSuffixformat in payment validation path before request translationTest plan
node packages/account-sdk/compile-assets.cjsyarn workspace @base-org/account typecheckyarn workspace @base-org/account test --runyarn lintyarn workspace @base-org/account test --run src/interface/payment/pay.test.ts src/interface/payment/utils/translatePayment.test.tsMade with Cursor