fix: remove redundant console.error calls in getPaymentStatus#264
Closed
mehmetkr-31 wants to merge 1 commit intobase:masterfrom
Closed
fix: remove redundant console.error calls in getPaymentStatus#264mehmetkr-31 wants to merge 1 commit intobase:masterfrom
mehmetkr-31 wants to merge 1 commit intobase:masterfrom
Conversation
Collaborator
🟡 Heimdall Review Status
|
Both console.error calls are redundant since errors are already captured by the telemetry system via logPaymentStatusCheckError. Removing them avoids leaking internal error details to the browser console in production while keeping the structured telemetry logging intact. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mehmetkr-31
force-pushed
the
fix/remove-console-error-getPaymentStatus
branch
from
7561f9a to
1356d83
Compare
Author
|
Closing in favor of #267 which includes this change as part of a broader structured error propagation across the entire payment module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
console.error()calls ingetPaymentStatus()that were redundant with the existing telemetry system (logPaymentStatusCheckError)Why
Both error paths already call
logPaymentStatusCheckError()for structured observability. Theconsole.errorcalls add no diagnostic value and expose internal error objects to end users' browser consoles.Test plan
getPaymentStatus.test.tspassyarn lint)yarn buildin account-sdk package)🤖 Generated with Claude Code