Skip to content

chore: add Node 24 to CI matrix and bump dev Node to 22#270

Merged
fan-zhang-sv merged 1 commit intomasterfrom
chore/support-node-24
Apr 9, 2026
Merged

chore: add Node 24 to CI matrix and bump dev Node to 22#270
fan-zhang-sv merged 1 commit intomasterfrom
chore/support-node-24

Conversation

@fan-zhang-sv
Copy link
Copy Markdown
Collaborator

Summary

  • Add Node 24.x (current Active LTS) to the CI test matrix alongside 20.x and 22.x
  • Bump .nvmrc from 20.18.0 to 22 since Node 20 reaches EOL on April 30, 2026
  • Add engines: { node: ">=20" } to @base-org/account and @base-org/account-ui so consumers get a clear minimum version signal

Test plan

  • CI passes on all three matrix versions (Node 20, 22, 24)
  • Verify builds succeed with the updated .nvmrc

Made with Cursor

- Add Node 24.x (current Active LTS) to the CI test matrix
- Bump .nvmrc from 20.18.0 to 22 (Node 20 EOLs April 30, 2026)
- Add engines field (>=20) to account-sdk and account-ui package.json

Made-with: Cursor
@linear
Copy link
Copy Markdown

linear bot commented Apr 8, 2026

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Apr 8, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@fan-zhang-sv fan-zhang-sv merged commit da125bf into master Apr 9, 2026
10 checks passed
@fan-zhang-sv fan-zhang-sv deleted the chore/support-node-24 branch April 9, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants