fix(readme): add missing await on provider.request() calls#273
Open
Sertug17 wants to merge 1 commit intobase:masterfrom
Open
fix(readme): add missing await on provider.request() calls#273Sertug17 wants to merge 1 commit intobase:masterfrom
Sertug17 wants to merge 1 commit intobase:masterfrom
Conversation
Collaborator
🟡 Heimdall Review Status
|
Sertug17
force-pushed
the
fix/readme-missing-await
branch
from
8369c1d to
f3294a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #272
Added missing
awaiton twoprovider.request()calls in the README examples.Without
await, the variables would hold a Promise instead of the actual result, causing unexpected behavior for anyone copying the examples.