Skip to content

ci: rename release-account-manual.yml to release-account.yml#289

Merged
stephancill merged 1 commit intomasterfrom
chore/rename-release-account-workflow
Apr 28, 2026
Merged

ci: rename release-account-manual.yml to release-account.yml#289
stephancill merged 1 commit intomasterfrom
chore/rename-release-account-workflow

Conversation

@stephancill
Copy link
Copy Markdown
Collaborator

Summary

Aligns the manual publish workflow filename with the npm Trusted Publisher entry for @base-org/account.

The npm Trusted Publisher for @base-org/account is configured for workflow filename release-account.yml with environment publish. The previous filename release-account-manual.yml caused npm to reject OIDC-authenticated publishes with a misleading 404 (npm returns 404 instead of 403 for unauthorized scope writes). This is what blocked the manual republish attempt of @base-org/account@2.5.5 (run 25020384976).

After this change, the workflow can be dispatched manually to publish a version that release-please has tagged on master but not yet pushed to npm.

The [DEPRECATED] markers are removed since this workflow is now the canonical publish path. release-please.yml cannot publish until its filename is also added as a trusted publisher entry on npm — that's tracked separately.

How did you test your changes?

  • Verified the new filename matches the npm Trusted Publisher configuration for @base-org/account.
  • File contents are unchanged (only the leading comment block and name: field were updated to remove the DEPRECATED markers).
  • After merge, dispatching the workflow with packageVersion=2.5.5 should successfully publish the missing 2.5.5 version to npm.

Aligns the workflow filename with the npm Trusted Publisher entry
for @base-org/account so OIDC-authenticated publishes succeed.

The npm Trusted Publisher for @base-org/account expects workflow
filename 'release-account.yml' with environment 'publish'. The
previous filename 'release-account-manual.yml' caused npm to reject
publishes with a misleading 404 (npm returns 404 instead of 403 for
unauthorized scope writes).

Removes the [DEPRECATED] markers since this workflow is now the
canonical publish path until release-please.yml is wired up to its
own trusted publisher entry.
@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Apr 28, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@github-actions
Copy link
Copy Markdown
Contributor

Review: no issues found.

This is a CI-only change — renaming release-account-manual.yml to release-account.yml and updating the comment block / workflow name field. The workflow logic, permissions (id-token: write, environment: publish), and steps are unchanged.

The PR title ci: rename release-account-manual.yml to release-account.yml follows Conventional Commits correctly — no fix needed.

Copy link
Copy Markdown
Collaborator

@fan-zhang-sv fan-zhang-sv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@stephancill stephancill merged commit 5c9c044 into master Apr 28, 2026
12 checks passed
@stephancill stephancill deleted the chore/rename-release-account-workflow branch April 28, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants