fix(sub-account): throw instead of return Error in sendRequestToSubAccountSigner catch block#328
Open
Nexory wants to merge 2 commits into
Open
fix(sub-account): throw instead of return Error in sendRequestToSubAccountSigner catch block#328Nexory wants to merge 2 commits into
Nexory wants to merge 2 commits into
Conversation
…countSigner catch block The catch block previously did `return new Error(...)` which causes the async function's Promise to resolve with the Error as a value rather than reject. The caller's .catch() never fires, the Error is silently swallowed downstream, and the calling code can mistakenly proceed as if the operation succeeded (the caller would need to instanceof-check the resolved value to detect the failure). This patch throws so the Promise rejects properly and the caller's error-handling path executes. Closes base#326
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #326
Catch block returns Error instead of throwing — Issue #326
The diff is a 1-line behavioral fix. See Issue #326 for the full rationale.