Apply PRD DEFAULT row decisions across token interfaces#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Incorporates the team's DEFAULT row decisions from the BOP Home PRD tab, reconciles the variant interfaces with the new IDefaultToken behavior, and aligns errors and events with the OZ AccessControl convention (ERC20 / ERC2612 prefixes dropped per local convention).
IDefaultToken (the bulk)
IStablecoin (75% line reduction, 223 → 56)
Trimmed to just `currency()`. Per-minter rate limiting and ERC-3009 are now wrapper / periphery concerns. Bridge's TIP20Controller pattern and CCS's mint flow are both expressible via wrapping contracts that hold `MINT_ROLE` on the precompile. Sanctions seizure is also a periphery concern.
ISecurityToken
Removed redundant `redeem` family (inherited from IDefaultToken) and `redeemPolicyId` (folded into the compound `transferPolicyId` redeemer slot). Removed conflicting `NameUpdated` / `SymbolUpdated` events (use inherited events plus `Announcement` correlation by tx hash). Added `ISSUER_ROLE` declaration. Changed `adminBurn` role from `BURN_BLOCKED_ROLE` (no longer exists) to `ISSUER_ROLE` for consistency with `adminMint`. All security-specific features preserved: announcements, share ratio, `create`, `adminMint` / `adminBurn`, security identifiers, `updateName` / `updateSymbol` with announcement coupling.
ITokenFactory
Dropped `defaultAdminDelay` (no two-step admin) and `redeemPolicyId` from all three params structs. Added `minimumRedeemable` to Default and Stablecoin params (since redeem moved to default). Updated all NatSpec to remove MINTABLE references and document the cap-based fixed-supply pattern.
Capabilities.sol
Default bits trimmed to `PAUSABLE` (1<<0) and `CAP_MUTABLE` (1<<1). Stablecoin variant bits removed entirely. Security variant bits unchanged. Presets updated accordingly.
PauseVectors.sol (new)
Library defining the granular pause bitmask: `MINT`, `BURN`, `TRANSFER`, `REDEEM` at bits 0..3.
`forge build` clean across all interface files.