fix: reduce gzip noise in proxy DebugResponse#172
Merged
Conversation
DebugResponse unconditionally tried gzip decompression on every proxied response, logging at Error level when it failed. Most responses are plain JSON (not gzip-compressed), causing hundreds of spurious error lines per second. Fall back to logging the raw body at Debug level when the response is not gzip-encoded.
Collaborator
✅ Heimdall Review Status
|
0x00101010
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DebugResponseunconditionally tried gzip decompression on every proxied response, logging atErrorlevel when it failed. Most upstream nodes respond with plain JSON (not gzip-compressed), causing hundreds of spurious error lines per second:This made benchmark output nearly unreadable.
Fix
When
gzip.NewReaderfails (response isn't gzip'd), fall back to logging the raw body atDebuglevel instead ofError. Same for close/read errors — downgraded fromErrortoDebug.Testing
Tested locally end-to-end with the load-test benchmark — gzip noise is completely eliminated from output.