Skip to content

Conversation

@VolodymyrBg
Copy link

This commit adds additional validation checks for the DisputeGameFactory upgrade process:

Pre-checks:

  • Verify that new implementations are valid contracts
  • Ensure the DisputeGameFactory owner is correct
  • Confirm that new implementations differ from current ones

Post-checks:

  • Verify implementations are correctly set
  • Check that implementations have valid versions
  • Ensure implementations are properly initialized
  • Confirm that game types are correctly registered

These additional checks improve the safety and reliability of the upgrade process
by catching potential issues before and after the implementation change.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 1, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wbnns wbnns added the base protocol review To be reviewed by the Base web team label Apr 19, 2025
@jackchuma
Copy link
Contributor

These checks are not needed beyond what is already there. Thanks though!

@jackchuma jackchuma closed this Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

base protocol review To be reviewed by the Base web team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants