feat(sepolia): upgrade SystemConfig to increase MAX_GAS_LIMIT to 2B#677
Merged
Conversation
Prerequisite for the 1.2B gas limit + elasticity 15 task. The current maximumGasLimit of 500M rejects setGasLimit(1200000000). Patches base-contracts SystemConfig v3.13.2 to set MAX_GAS_LIMIT = 2B, deploys a new implementation, and upgrades the proxy via ProxyAdmin.
Collaborator
✅ Heimdall Review Status
|
…d GEN_VALIDATION Replace outdated eip712sign/state-diff approach with the modern signer-tool workflow used by recent tasks (multiproof, zk-config): - Rewrite Makefile to use GEN_VALIDATION, MULTISIG_APPROVE, MULTISIG_EXECUTE - Add SIGNER_TOOL_PATH, validate-config, gen-validation-base/op targets - Add FACILITATOR.md with deployment/signing/execution instructions - Update README to reference make sign-task instead of manual eip712sign - Add RECORD_STATE_DIFF=true and signer-tool re-export comments to .env - Clean up deps to extend root Makefile targets instead of duplicating them
roger-bai-coinbase
approved these changes
May 7, 2026
jackchuma
approved these changes
May 7, 2026
leopoldjoy
added a commit
that referenced
this pull request
May 7, 2026
… gas+elasticity task Add EIP-1967 implementation slot override to _simulationOverrides so the simulation can set gasLimit to 1.2B before the prerequisite MAX_GAS_LIMIT upgrade (PR #677) is executed on-chain. The override points the SystemConfig proxy to the new implementation (0x4ABA707D) with MAX_GAS_LIMIT=2B. Generate base-signer.json validation file via signer-tool.
leopoldjoy
added a commit
that referenced
this pull request
May 7, 2026
* feat(sepolia): increase gas limit to 1.2B and elasticity to 15 Preserves the current gas target at 80M while increasing burst capacity: current: gas_limit=400M, elasticity=5 -> target=80M proposed: gas_limit=1200M, elasticity=15 -> target=80M DA footprint gas scalar set to 446, anchored to L1 blob limit: 1,200,000,000 / (21 * 128,000) = 446 Depends on sepolia/2026-05-06-increase-max-gas-limit (PR #677) to raise MAX_GAS_LIMIT from 500M to 2B first. * refactor(sepolia): add SIGNER_TOOL_PATH and gen-validation section to gas+elasticity task - Add SIGNER_TOOL_PATH = ../../signer-tool for consistency with latest tasks - Update FACILITATOR.md with gen-validation/gen-validation-rollback instructions and concrete task directory paths * chore: update BASE_CONTRACTS_COMMIT to latest (4ff644d5) * chore: update BASE_CONTRACTS_COMMIT to latest (415a6a8c) and fix import paths * chore: update BASE_CONTRACTS_COMMIT to latest (e8fe64dc) * feat(sepolia): add validation file and SystemConfig impl override for gas+elasticity task Add EIP-1967 implementation slot override to _simulationOverrides so the simulation can set gasLimit to 1.2B before the prerequisite MAX_GAS_LIMIT upgrade (PR #677) is executed on-chain. The override points the SystemConfig proxy to the new implementation (0x4ABA707D) with MAX_GAS_LIMIT=2B. Generate base-signer.json validation file via signer-tool. * fix(sepolia): add pre-checks for FROM values in gas+elasticity script Address review feedback: verify current on-chain values match expected FROM values (gas limit, elasticity, denominator, DA footprint gas scalar) before building the transaction calls. * feat(sepolia): add rollback validation file and fix pre-checks for rollback compatibility Add base-signer-rollback.json validation file for the rollback scenario (swapped OLD/NEW values, nonce offset +1). Fix pre-checks in _buildCalls: guard with a condition that detects rollback simulation (on-chain values differ from FROM values). Since _buildCalls runs before _simulationOverrides are applied, the raw on-chain values are visible. The pre-checks now pass through when simulation overrides are active, relying on _postCheck for final state validation. * docs(sepolia): improve DA footprint gas scalar comment with soft/hard cap formulas Incorporate Niran's formulas and concrete cap values into a neutral documentation comment that describes what the current scalar (446) produces without implying correctness of alternative approaches.
leopoldjoy
added a commit
that referenced
this pull request
May 9, 2026
* chore(sepolia): remove SYSTEM_CONFIG_IMPL override and regenerate validations The prerequisite MAX_GAS_LIMIT upgrade (PR #677) is now executed on-chain, so the SYSTEM_CONFIG_IMPL simulation override is no longer needed. - Remove SYSTEM_CONFIG_IMPL from .env and Makefile gen-validation targets - Simplify _simulationOverrides() to only handle rollback overrides - Regenerate base-signer.json and base-signer-rollback.json - Add task creator signature (creator-signature.json) * fix: restore human-readable descriptions in validation files * fix: re-sign task creator signature after validation description fix * chore: add base and SC facilitator signatures * fix: replace SC facilitator signature * fix: replace SC facilitator signature (attempt 3) * chore(sepolia): mark gas limit + elasticity increase as executed Add execution artifact and update README status to EXECUTED with Etherscan link: 0x62f0de50c147128a4faa7c8c93686f8fd716a18824678e93f72b6c4c979d132e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAX_GAS_LIMITfrom 500M to 2BSystemConfigv3.13.2 at commitbe7c7a6to change the constant and version stringDeploySystemConfig.s.sol) and upgrade script (UpgradeSystemConfig.s.sol)MAX_GAS_LIMITconstant andversion()are modifiedPrerequisite For
This is a prerequisite for the Sepolia 1.2B gas limit + elasticity 15 task (separate PR), which sets
gas_limit = 1,200,000,000. The currentmaximumGasLimitof 500M rejects that value.Parameter Changes
MAX_GAS_LIMITversion()3.13.23.13.2+max-gas-limit-2000MSigning Flow
This upgrade goes through the ProxyAdmin owner Safe (
0x0fe884546476dDd290eC46318785046ef68a0BA9), which requires signatures from both Base and OP signers.