Skip to content

Remove IGnosisSafe interface copy#102

Merged
mdehoog merged 1 commit intomainfrom
michael/remove-safe-interface
Oct 29, 2024
Merged

Remove IGnosisSafe interface copy#102
mdehoog merged 1 commit intomainfrom
michael/remove-safe-interface

Conversation

@mdehoog
Copy link

@mdehoog mdehoog commented Oct 29, 2024

This breaks integration into https://github.com/ethereum-optimism/superchain-ops because they depend on the optimism version, and so we get errors:

Error (9553): Invalid type for argument in function call. Invalid implicit conversion from contract IGnosisSafe to contract IGnosisSafe requested.
  --> script/NestedSignFromJson.s.sol:19:14:
   |
19 |         sign(_signerSafe);
   |              ^^^^^^^^^^^

@mdehoog mdehoog requested a review from stevieraykatz October 29, 2024 01:17
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 29, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@mdehoog mdehoog force-pushed the michael/remove-safe-interface branch from 0c53a15 to a05d260 Compare October 29, 2024 01:18
@mdehoog mdehoog merged commit 488e7a6 into main Oct 29, 2024
@mdehoog mdehoog deleted the michael/remove-safe-interface branch October 29, 2024 01:20
mdehoog pushed a commit that referenced this pull request Oct 29, 2024
mdehoog pushed a commit that referenced this pull request Oct 29, 2024
* Remove IGnosisSafe from function signatures

* Revert "Remove IGnosisSafe interface copy (#102)"

This reverts commit 488e7a6.

* forge fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants