Skip to content

chore: remove opcm#272

Merged
jackchuma merged 19 commits intomainfrom
chore/rm-opcm
May 7, 2026
Merged

chore: remove opcm#272
jackchuma merged 19 commits intomainfrom
chore/rm-opcm

Conversation

@jackchuma
Copy link
Copy Markdown
Contributor

@jackchuma jackchuma commented May 6, 2026

Summary

  • Remove the OPContractsManager (OPCM) and OPContractsManagerStandardValidator production contracts, their interfaces, ABI/storage snapshots, and the dedicated opcm-upgrade-checks script.
  • Introduce scripts/deploy/SystemDeploy.s.sol, a single script that inlines and simplifies the full system deploy + upgrade logic that previously lived inside OPCM.
  • Inline and simplify deployment and upgrade logic in DeployImplementations, Deploy, and DeployOPChain so the scripts no longer rely on OPCM as an intermediary.
  • Extract OPCM-owned types into scripts/libraries/Types.sol so callers consume them directly from script types.
  • Replace the onchain standard validator with test/setup/StandardSystemAssertions.sol, a test-only assertion harness, and update ForkLive/Setup accordingly.
  • Move OPCM-era deploy tests (DeployImplementations.t.sol, DeployOPChain.t.sol, DeploySuperchain.t.sol) from test/opcm/ to test/deploy/ and add test/deploy/SystemDeploy.t.sol.
  • Clean up supporting tooling: drop OPCM entries from foundry.toml, the justfile, scripts/checks/interfaces, and scripts/checks/test-validation/exclusions.toml; refresh snapshots accordingly.

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented May 6, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@jackchuma jackchuma marked this pull request as ready for review May 7, 2026 11:18
Comment thread scripts/deploy/SystemDeploy.s.sol
@jackchuma jackchuma requested a review from xenoliss May 7, 2026 16:09
@jackchuma jackchuma merged commit c129f28 into main May 7, 2026
7 checks passed
@jackchuma jackchuma deleted the chore/rm-opcm branch May 7, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants