fix: remove unused InvalidProofThreshold error from AggregateVerifier#278
Merged
Merged
Conversation
The InvalidProofThreshold custom error was declared but never thrown anywhere in the codebase. PROOF_THRESHOLD is a compile-time constant (hardcoded to 1), so the validation guard this error was intended for was never needed. Remove the dead declaration and its ABI entry. Ref: Immunefi #75919
Collaborator
✅ Heimdall Review Status
|
roger-bai-coinbase
previously approved these changes
May 11, 2026
cb-heimdall
dismissed
roger-bai-coinbase’s stale review
Approved review 4266411359 from roger-bai-coinbase is now dismissed due to new commit. Re-request for approval.
roger-bai-coinbase
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InvalidProofThresholdcustom error declaration fromAggregateVerifier.soland its corresponding ABI snapshot entry.PROOF_THRESHOLDis a compile-time constant hardcoded to1, so no runtime validation guard was ever needed.Ref: Immunefi #75919