Skip to content

Improve signer output for ledger signing#28

Merged
anikaraghu merged 1 commit intomainfrom
michael/improved-ledger-output
Jul 18, 2023
Merged

Improve signer output for ledger signing#28
anikaraghu merged 1 commit intomainfrom
michael/improved-ledger-output

Conversation

@mdehoog
Copy link

@mdehoog mdehoog commented Jul 18, 2023

  • adds Data sent to ledger, awaiting signature... output
  • adds output of EIP-712 domain and message hashes for verification during signature

Copy link
Contributor

@anikaraghu anikaraghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@anikaraghu anikaraghu merged commit 976c6b0 into main Jul 18, 2023
@anikaraghu anikaraghu deleted the michael/improved-ledger-output branch July 18, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants