Merged
Conversation
anikaraghu
commented
Jun 7, 2023
|
|
||
| function run() public { | ||
| utils = new Utils(); | ||
| Utils.AddressesConfig memory addressCfg = utils.readAddressesFile(); |
Contributor
Author
There was a problem hiding this comment.
Worth nothing that with this approach, addresses.json will have to be added to the inputs folder for that deploy directory, which would mean addresses.json being duplicated in multiple places. Should be fine because none of the addresses should change, but an alternative would be that all addresses we use can be explicitly passed into the relevant script and defined in the .env file
mdehoog
approved these changes
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add scripts for