Support submitting approveHash onchain, rather than signatures#34
Merged
anikaraghu merged 1 commit intomainfrom Jul 31, 2023
Merged
Support submitting approveHash onchain, rather than signatures#34anikaraghu merged 1 commit intomainfrom
anikaraghu merged 1 commit intomainfrom
Conversation
anikaraghu
reviewed
Jul 31, 2023
| IMulticall3.Call3[] memory nestedCalls = _buildCalls(); | ||
| IMulticall3.Call3 memory call = _generateApproveCall(nestedSafeAddress, nestedCalls); | ||
|
|
||
| address[] memory approvers = _getApprovers(_signerSafe, toArray(call)); |
Contributor
There was a problem hiding this comment.
Super helpful to automatically grab any onchain signatures! I was manually trying to construct the prevalidated signatures 😅 Could we add a comment mentioning that this happens automatically?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow support for nested-nested-multisigs, e.g. there's a safe that is a signer for the nested safe (3 layers of safes). Instead of providing a signature, this inner safe can submit an
approveHashto the middle safe, which will eventually allowapproveHashon the outer safe.