feat: override safe nonce and verify signatures#52
Conversation
tynes
reviewed
Nov 6, 2023
| uint256 nonce = safe.nonce(); | ||
| console.log("Safe current nonce:", nonce); | ||
|
|
||
| uint256 nonceOverride = vm.envUint("SAFE_NONCE"); |
Contributor
There was a problem hiding this comment.
uint256 nonce = vm.envOr("SAFE_NONCE", safe.nonce());
mdehoog
approved these changes
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a new environment variable called
SAFE_NONCEwhich allow callers to override the Safe contract nonce.This is useful when crafting future transactions ahead of time and collecting signatures.
It also provides a new
function verify(bytes memory _signatures)to make sure the collected signatures are valid to execute the transaction.It is intended to work as: