Skip to content

fix: safe_nonce env shouldnt be required#55

Merged
anikaraghu merged 1 commit intobase:mainfrom
felipe-op:felipe/safe-nonce-shouldnt-be-required
Dec 6, 2023
Merged

fix: safe_nonce env shouldnt be required#55
anikaraghu merged 1 commit intobase:mainfrom
felipe-op:felipe/safe-nonce-shouldnt-be-required

Conversation

@felipe-op
Copy link
Contributor

@felipe-op felipe-op commented Nov 20, 2023 •
edited
Loading

When SAFE_NONCE is not set, the script fails with

    ├─ [0] VM::envString("SAFE_NONCE") [staticcall]
    │   └─ ← environment variable "SAFE_NONCE" not found
    └─ ← environment variable "SAFE_NONCE" not found

This change replaces envString to envOr defaulting to an empty string.

@felipe-op
Copy link
Contributor Author

felipe-op commented Dec 1, 2023

@anikaraghu can you please merge this PR? I dont have write access to base-org/contracts.

@wbnns wbnns added the state: in progress This is being worked on label Dec 5, 2023
@anikaraghu anikaraghu merged commit 6a9841b into base:main Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anikaraghu anikaraghu anikaraghu approved these changes

Assignees

No one assigned

Labels

state: in progress This is being worked on

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@felipe-op @anikaraghu @wbnns