Skip to content

fix(docs): replace broken appLogoUrl example (base.org/logo.png returns 404) #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ygd58 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(docs): replace broken appLogoUrl example (base.org/logo.png returns 404) #1317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/base-account/improve-ux/batch-transactions.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ import { createBaseAccountSDK } from "@base-org/account";

const sdk = createBaseAccountSDK({
appName: "Base Account SDK Demo",
appLogoUrl: "https://base.org/logo.png",
appLogoUrl: "https://avatars.githubusercontent.com/u/108554348?s=200",
});

const provider = sdk.getProvider();
Expand All @@ -66,7 +66,7 @@ import { numberToHex, parseEther } from "viem";

const sdk = createBaseAccountSDK({
appName: "Batch Transaction Demo",
appLogoUrl: "https://base.org/logo.png",
appLogoUrl: "https://avatars.githubusercontent.com/u/108554348?s=200",
});

const provider = sdk.getProvider();
Expand Down Expand Up @@ -165,7 +165,7 @@ const NFT_CONTRACT_ADDRESS = "0x82039e7C37D7aAc98D0F4d0A762F4E0d8c8DC273";
async function approveAndTransfer() {
const sdk = createBaseAccountSDK({
appName: "ERC-20 Batch Demo",
appLogoUrl: "https://base.org/logo.png",
appLogoUrl: "https://avatars.githubusercontent.com/u/108554348?s=200",
});

const provider = sdk.getProvider();
Expand Down
4 changes: 2 additions & 2 deletions docs/base-account/improve-ux/spend-permissions.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ import { base } from "viem/chains";

const sdk = createBaseAccountSDK({
appName: 'Base Account SDK Demo',
appLogoUrl: 'https://base.org/logo.png',
appLogoUrl: 'https://avatars.githubusercontent.com/u/108554348?s=200',
appChainIds: [base.id],
});

Expand Down Expand Up @@ -201,7 +201,7 @@ import { base } from "viem/chains";

const sdk = createBaseAccountSDK({
appName: 'Base Account SDK Demo',
appLogoUrl: 'https://base.org/logo.png',
appLogoUrl: 'https://avatars.githubusercontent.com/u/108554348?s=200',
appChainIds: [base.id],
});

Expand Down
8 changes: 4 additions & 4 deletions docs/base-account/improve-ux/sponsor-gas/paymasters.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ the [Coinbase Developer Platform documentation](https://docs.cdp.coinbase.com/pa

const sdk = createBaseAccountSDK({
appName: 'Paymaster Demo',
appLogoUrl: 'https://base.org/logo.png',
appLogoUrl: 'https://avatars.githubusercontent.com/u/108554348?s=200',
appChainIds: [base.constants.CHAIN_IDS.baseSepolia], // or base.constants.CHAIN_IDS.base for mainnet
});

Expand Down Expand Up @@ -148,7 +148,7 @@ the [Coinbase Developer Platform documentation](https://docs.cdp.coinbase.com/pa
async function sendSponsoredTransaction() {
const sdk = createBaseAccountSDK({
appName: 'Paymaster Demo',
appLogoUrl: 'https://base.org/logo.png',
appLogoUrl: 'https://avatars.githubusercontent.com/u/108554348?s=200',
appChainIds: [base.constants.CHAIN_IDS.baseSepolia],
});

Expand Down Expand Up @@ -213,7 +213,7 @@ the [Coinbase Developer Platform documentation](https://docs.cdp.coinbase.com/pa
async function sendMultipleSponsoredTransactions() {
const sdk = createBaseAccountSDK({
appName: 'Paymaster Demo',
appLogoUrl: 'https://base.org/logo.png',
appLogoUrl: 'https://avatars.githubusercontent.com/u/108554348?s=200',
appChainIds: [base.constants.CHAIN_IDS.baseSepolia],
});

Expand Down Expand Up @@ -264,7 +264,7 @@ the [Coinbase Developer Platform documentation](https://docs.cdp.coinbase.com/pa
async function checkPaymasterSupport() {
const sdk = createBaseAccountSDK({
appName: 'Paymaster Demo',
appLogoUrl: 'https://base.org/logo.png',
appLogoUrl: 'https://avatars.githubusercontent.com/u/108554348?s=200',
appChainIds: [base.constants.CHAIN_IDS.baseSepolia],
});

Expand Down
4 changes: 2 additions & 2 deletions docs/base-account/improve-ux/sub-accounts.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ import { base } from 'viem/chains';
// Initialize SDK with Sub Account configuration
const sdk = createBaseAccountSDK({
appName: 'Base Account SDK Demo',
appLogoUrl: 'https://base.org/logo.png',
appLogoUrl: 'https://avatars.githubusercontent.com/u/108554348?s=200',
appChainIds: [base.id],
});

Expand Down Expand Up @@ -339,7 +339,7 @@ If your users' Sub Accounts will be funded manually, you can disable Auto Spend
```tsx page.tsx
const sdk = createBaseAccountSDK({
appName: 'Base Account SDK Demo',
appLogoUrl: 'https://base.org/logo.png',
appLogoUrl: 'https://avatars.githubusercontent.com/u/108554348?s=200',
appChainIds: [base.id],
subAccounts: {
funding: 'manual', // Disable auto spend permissions
Expand Down
2 changes: 1 addition & 1 deletion docs/base-account/quickstart/web-react.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export default function Home() {
const sdk = createBaseAccountSDK(
{
appName: 'Base Account Quick-start',
appLogoUrl: 'https://base.org/logo.png',
appLogoUrl: 'https://avatars.githubusercontent.com/u/108554348?s=200',
}
);

Expand Down
2 changes: 1 addition & 1 deletion docs/base-account/quickstart/web.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ This guide uses the CDN approach for simplicity.
const provider = window
.createBaseAccountSDK({
appName: "Base Account Quick-start",
appLogoUrl: "https://base.org/logo.png",
appLogoUrl: "https://avatars.githubusercontent.com/u/108554348?s=200",
})
.getProvider();
const statusDiv = document.getElementById("status");
Expand Down