Update DataCallback to Event-Based Structure#698
Merged
Conversation
Collaborator
✅ Heimdall Review Status
|
youssefea
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Updated DataCallback capability structure from flat request-based model to event-based architecture. The capability now supports three distinct event types:
initiated,preSign, andpostSign. Each event can include optional context data, andpreSignevents contain the data requests array (previously at root level).Changes:
DataCallbackCapabilitytype to useeventsarray instead ofrequestsDataCallbackEventtype withtype,context, andrequestsfieldsNotes to reviewers
The API surface changes from:
To:
How has it been tested?
Documentation changes validated through: