fix: default CLIENT to reth in docker-compose.yml#1034
Open
fix: default CLIENT to reth in docker-compose.yml#1034
Conversation
README.md already documents reth as the default execution client, but docker-compose.yml used geth as the fallback value for the CLIENT variable. This meant that running docker compose up without explicitly setting CLIENT=reth would silently start geth instead of reth. After Base V1 activates (early May 2026), only base-reth-node supports the network. Having geth as the implicit default increases the risk of operators missing the migration. Changed the CLIENT fallback from geth to reth in both the execution and node service Dockerfile references so the default behaviour matches the documented default and the post-V1 requirement. Operators who intentionally run geth can still do so by setting CLIENT=geth explicitly in their env file. Fixes base#1010.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
README.md documents
rethas the default execution client:But
docker-compose.ymlusesgethas the fallback:Running
docker compose upwithout settingCLIENTsilently startsgethinstead ofreth. This contradicts the documented default and, more critically, increases the risk of operators missing the Base V1 migration — after V1 activates (early May 2026), onlybase-reth-nodewill follow the canonical chain.Fix
Change the
CLIENTfallback fromgethtorethin both service definitions indocker-compose.yml. Operators who intentionally rungethcan still do so by settingCLIENT=gethexplicitly in their env file.Impact
CLIENToverride still works as beforeFixes #1010