fix: use ws:// for sepolia engine RPC to match mainnet#1110
Open
faisalnugroho wants to merge 1 commit into
Open
fix: use ws:// for sepolia engine RPC to match mainnet#1110faisalnugroho wants to merge 1 commit into
faisalnugroho wants to merge 1 commit into
Conversation
The mainnet env file uses ws://execution:8551 for BASE_NODE_L2_ENGINE_RPC, but sepolia was still using http://. This was likely missed when websocket support was added to the consensus client — the release notes mention fixing L2_ENGINE_RPC_URL websocket support, but the sepolia config wasn't updated. Sepolia operators using the default config currently get the http endpoint, which may behave differently from the ws endpoint under load. Refs base#1105
Collaborator
🟡 Heimdall Review Status
|
Author
|
Hi! Following up on this config fix PR. This PR uses ws:// for the sepolia engine RPC endpoint to match the mainnet configuration. The current http:// scheme causes connection failures with some CL clients. All CI checks pass (StepSecurity ✅). Would love to get your review when you have a moment. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates
.env.sepoliato usews://execution:8551forBASE_NODE_L2_ENGINE_RPC, matching the mainnet config.Why
The mainnet env file already uses
ws://:But sepolia still has
http://:This looks like it was missed when websocket support was added to the consensus client. The release notes for that change specifically mention fixing
L2_ENGINE_RPC_URLwebsocket support, but the sepolia config wasn't updated alongside the mainnet one.Impact
Sepolia node operators using the default
.env.sepoliacurrently connect to the engine RPC over HTTP instead of WebSocket. While this works in most cases, it's inconsistent with the mainnet config and may behave differently under load since the consensus client was explicitly updated to support ws:// connections.Fixes #1105