Conversation
Persist chain data
Contributor
|
Heya! Thanks for the suggestion here and welcome to the project! From my POV, I definitely see where you are coming from, and yeah, if one removes the container that is a long time to restore the chain data. Maybe one concern (possibly others) is that this separates the data from the container, and leaves an artifact/remnant once the container is removed (a big one). But let's see what others think! 👍 Side note, but tangential: we're working on making snapshots of chain data available to reduce sync time required in the event the container is removed and/or needs to be restored. |
added 2 commits
June 15, 2023 12:56
# Conflicts: # docker-compose.yml
roberto-bayardo
approved these changes
Jun 15, 2023
Collaborator
|
Review Error for roberto-bayardo @ 2023-06-15 23:40:28 UTC |
roberto-bayardo
approved these changes
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently geth data is stored within the container. This means all chaindata is lost whenever the container is destroyed, for example when upgrading to the latest version using
docker-compose downinstead ofdocker-compose stop. This can be prevented by volume mounting the data directory to a directory on the host machine, which this PR proposes.