Conversation
…, also you dont need to have sh entrypoint with the interpreter
Contributor
|
Heya! Thanks for this PR! We'll do our best to review this as soon as we can. |
roberto-bayardo
approved these changes
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This updates the dockerfile and compose scripts slightly to cleanup some things and follow some best practices around docker
Remove the whole local git repo configuration that is done to build both geth and optimism repos, as it is creates unnecessary complexity. Instead simply download github public tarballs of the sha references. Another additional benefit is that this can use
sha256sumchecking on the tarballs. In order to useADD --checksum=sha256:you must use the docker# syntax=docker/dockerfile:1-labshttps://docs.docker.com/engine/reference/builder/#syntaxCleanup
/var/lib/apt/listsas this is unnecessary bloat in the imageRemove the
.shfrom the entrypoint files as they already have interpreters and exectuable files generally do not have extensions.Removes the
"sh"command to run the entrypoints in the docker compose file, because of the same reason, the scripts havebashinterpretersOnly Copy the
geth-entrypointandop-node-entrypointscripts and the appropriategoerlifolder. The current docker image includes all the other files in this repo due to aCOPY . ., which is really not necessaryThe image reduction is about 20 mb
Testing
This builds the image via
docker compose up --buildand geth and op clients startup