Update geth-entrypoint#93
Merged
Conversation
Additng P2P_PORT
mdehoog
approved these changes
Aug 16, 2023
Contributor
mdehoog
left a comment
mdehoog
left a comment
There was a problem hiding this comment.
thanks for the contribution!
Just a quick note that, for op-stack chains, currently geth P2P doesn't do anything outside of mempool gossip, and Base has a private mempool, so this would only be useful if you want to share a mempool between a few nodes. That said, no issues with merging it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additng P2P_PORT into geth-entrypoint.
For Docker with host network it could be important.