-
Notifications
You must be signed in to change notification settings - Fork 42
feat(core): add in-memory mempool for 4337 user operations #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wlawt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic makes sense to me!
just to confirm my understanding of all the AA/ERC-4337 stuff going on ...
- this in-memory mempool, is similar to the "off-chain mempool" that currently exists?
- is the
pub trait Mempoola shared trait that op-rbuilder uses to fetch the userOps to build bundles out of? - i'm assuming there'll be a follow-up PR to add the userOp to the in-memory mempool after it passes the
validate_user_operationcheck in ingress-rpc? - i'm not sure if this makes sense, but, what's the role of the
user_op_queue_publishernow that we'll have the mempool? is it there to act as a buffer?
Nice questions, this mempool dosen't currently exist would actually be in the bundler i.e Rundler |
DeStefaniAndrei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What changed? Why?
This PR adds an in-memory mempool implementation for ERC-4337 user operations in account-abstraction-core, so we can enqueue, prioritize, and dequeue operations deterministically.
Key Changes:
◦ Introduces Mempool trait:
◦ MempoolImpl maintains an implementation of this