Skip to content

Conversation

@brendan-defi
Copy link
Collaborator

@brendan-defi brendan-defi commented Mar 28, 2025

What changed? Why?

  • replaced the ioredis implementation with upstash's package
  • removed vercel/kv
  • updated usage of vercel/kv to the upstash implementation

Notes to reviewers

How has it been tested?
Local curl:
image

Dev Env curl:
image

Have you tested the following pages?

BaseWeb

  • [] base.org
  • [] base.org/names
  • [] base.org/builders
  • [] base.org/ecosystem
  • [] base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

BaseDocs

  • [] docs.base.org
  • [] docs sub-pages

@vercel
Copy link

vercel bot commented Mar 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 10:42pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 10:42pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 28, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link
Collaborator

Review Error for dgca @ 2025-03-28 20:23:26 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

dgca
dgca previously approved these changes Mar 28, 2025
@brendan-defi brendan-defi marked this pull request as ready for review March 28, 2025 22:35
@cb-heimdall cb-heimdall dismissed dgca’s stale review March 28, 2025 22:38

Approved review 2726652482 from dgca is now dismissed due to new commit. Re-request for approval.

@brendan-defi brendan-defi merged commit df23f39 into master Mar 28, 2025
9 checks passed
@brendan-defi brendan-defi deleted the chore/upstash-redis branch March 28, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

base web review To be reviewed by the Base web team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants