Skip to content

[bugfix] Fix emoji renews#2559

Merged
stevieraykatz merged 3 commits intomasterfrom
fix-emoji-renews
Aug 1, 2025
Merged

[bugfix] Fix emoji renews#2559
stevieraykatz merged 3 commits intomasterfrom
fix-emoji-renews

Conversation

@stevieraykatz
Copy link
Member

What changed? Why?

Depends on #2558

Properly decodes the name for the renewal route.

Notes to reviewers

How has it been tested?

Have you tested the following pages?

BaseWeb

  • [] base.org
  • [] base.org/names
  • [] base.org/builders
  • [] base.org/ecosystem
  • [] base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Aug 1, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel
Copy link

vercel bot commented Aug 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2025 4:49pm

@stevieraykatz stevieraykatz marked this pull request as ready for review August 1, 2025 16:12
@stevieraykatz stevieraykatz merged commit 9b1b7b0 into master Aug 1, 2025
10 checks passed
@stevieraykatz stevieraykatz deleted the fix-emoji-renews branch August 1, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants