fix: skip kubeconfig update for in-cluster contexts#110
Merged
basebandit merged 3 commits intofeat/in-cluster-supportfrom Feb 1, 2026
Merged
fix: skip kubeconfig update for in-cluster contexts#110basebandit merged 3 commits intofeat/in-cluster-supportfrom
basebandit merged 3 commits intofeat/in-cluster-supportfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add check in SetCurrentContext to skip kubeconfig file update when ConfigPath is empty (in-cluster configurations). This prevents errors when switching to in-cluster contexts that don't have an associated kubeconfig file. Co-authored-by: basebandit <8973567+basebandit@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Address feedback on in-cluster support PR
fix: skip kubeconfig update for in-cluster contexts
Feb 1, 2026
Owner
|
@copilot the run lint job is failing with a gofmt error. |
Fix gofmt linting error by removing trailing whitespace on lines 122 and 132 in cluster/manager_test.go. Co-authored-by: basebandit <8973567+basebandit@users.noreply.github.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.