feat: modernize Kai for MCP 2025-06-18 spec #123
Merged
Merged
Conversation
…-lint 2.1.6->2.12.2
* feat(cluster): honor --request-timeout flag in K8s client config * fix(lint): replace WriteString(Sprintf) with Fprintf (staticcheck QF1012)
|
basebandit
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp-go0.28.0 → 0.52.0, k8s.io/* 0.33.1 → 0.34.1, golangci-lint 2.1.6 → 2.12.2, raises Go module version to 1.25.5.request.GetArguments()andmcp.CallToolParams{}in tests).readOnlyHint,destructiveHint,idempotentHint,openWorldHint,title) to all 66 tools./mcp(MCP spec 2025-03-26) alongside the legacy SSE transport (nowsse-legacy).--request-timeoutthroughcluster.Managerso the flag is actually honored by the K8s REST client (was silently ignored).Why
The repo was running on the 2-year-old MCP SDK and the deprecated HTTP+SSE transport, with no behavioural tool metadata and a
--request-timeoutflag the K8s client never read. Phase A is the protocol foundation — bumping the library, adopting the modern transport, and exposing tool annotations — that every subsequent phase (structured output, OAuth, resources, full K8s coverage) depends on.Test plan
go build ./...go vet ./...go test -race ./...golangci-lint run --timeout=3m(locally with v2.12.2)npx @modelcontextprotocol/inspector kai— verify annotations render onlist_pods,delete_pod, etc.kai -transport=streamable-http— confirm/mcphandshake withMcp-Session-Idworks.kai -request-timeout=2s— confirm a slow K8s call aborts at ~2s.Supersedes #114, #115, #116, #117.