Conversation
recordings lacks assignee data, so --assignee cannot work. Rather than silently returning unfiltered results, a hidden flag intercepts the request and redirects to the correct command: - With --in/--project: suggests `basecamp todos --assignee <person> --in <project>` - Without project scope: suggests `basecamp reports assigned [person]` The guard runs in PreRunE (root) or early RunE (list subcommand) so it fires before account validation. Hint arguments are %q-quoted for shell safety, and "me" matching is case-insensitive. Includes unit tests (11) and e2e tests (4) covering positional args, --type flag form, --in conditional path, non-"me" assignee preservation, case-insensitive "me" handling, and hidden flag assertions.
Agents were routing "my todos" queries to `recordings todos` which returns all todos with no assignee data, making per-person filtering impossible. Five edits steer agents toward `reports assigned` instead: - Invariant #6: reword to list cross-project exceptions coherently - Quick reference note: split guidance for assigned work vs type browsing - Quick reference table: add "My todos (cross-project)" row, annotate recordings row with "no assignee data" warning - Decision tree: add "My assigned work?" branch before type browsing, note that recordings cannot filter by person - Recordings section header: prefer reports assigned for assigned todos
github-actions
bot
added
commands
There was a problem hiding this comment.
Pull request overview
This PR fixes a routing issue where AI agents were incorrectly using basecamp recordings todos to find per-person assigned work, which is impossible because recordings lack assignee data. The fix introduces a hidden --assignee flag on the recordings and recordings list commands that intercepts misuse with context-aware redirect hints, and updates the SKILL.md agent guidance to steer toward basecamp reports assigned for assigned work queries.
Changes:
- Added hidden
--assigneeflag torecordings(PreRunE) andrecordings list(RunE) that returns a helpful redirect error with context-aware suggestions based on whether--inis present and whether the assignee is "me" or a specific person. - Updated SKILL.md in 5 places (invariants, quick reference table, decision tree, recordings section) to clarify that
reports assignedis the correct command for cross-project assigned work, and that recordings lack assignee data. - Updated the
agent_notesannotations on bothrecordingsandtodoscommands to reinforce the correct routing.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
internal/commands/recordings.go |
Added hidden --assignee flag, recordingsAssigneeRedirect function, and updated agent_notes annotation |
internal/commands/recordings_test.go |
New test file with 11 unit tests covering all redirect paths, edge cases, and hidden flag assertions |
internal/commands/todos.go |
Updated agent_notes annotation to direct agents to reports assigned instead of recordings |
skills/basecamp/SKILL.md |
Updated agent routing guidance in invariants, quick reference, decision tree, and recordings section |
e2e/recordings.bats |
Added 4 e2e tests covering both commands × both redirect paths |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recordings todos, which returns all todos with no assignee data — making per-person filtering impossible. The correct command isreports assigned.--assigneeflag torecordingsandrecordings listthat intercepts misuse with a context-aware redirect: suggeststodos --assignee ... --in ...when project-scoped, orreports assigned [person]when cross-project.reports assignedfor assigned work.Details
The redirect is implemented as a guard in PreRunE (root command) and early RunE (list subcommand), so it fires before account validation. Hint arguments use
%qquoting for shell safety, andmematching is case-insensitive.Test plan
recordings_test.go: positional args,--typeflag form,--inconditional path, non-"me" assignee preservation, case-insensitive "me", hidden flag assertionsrecordings.bats: both commands × both redirect pathsmake checkpasses (263 e2e, all unit tests, lint, vet, fmt, surface snapshot, provenance)