Surface error details in todo complete/reopen#252
Merged
Conversation
github-actions
bot
added
commands
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR updates the todo batch operations (done/todos complete and reopen/todos uncomplete) so that when all requested operations fail, the CLI returns a failure (including converted SDK error details) instead of emitting a misleading “Completed 0…” / “Reopened 0…” success response. This aligns the behavior with the existing multi-target error handling pattern used in comment.go.
Changes:
- Track the first API error during batch complete/uncomplete operations.
- When all operations fail, return a converted structured error (or usage error) for better automation/exit codes.
- Apply the same behavior to both
completeTodosandreopenTodos.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When all todo completion or reopen operations fail, the CLI now returns a structured error with the SDK error details (HTTP status, rate-limit hints, retryability) instead of silently returning a "Completed 0" success response. Mirrors the established pattern from comment.go.
jeremy
force-pushed
the
fix/todo-completion-errors
branch
from
efb1a99 to
7e94205
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Validates the error contract (not just message text) so structured error fields don't regress silently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
comment.go:318-365completeTodosandreopenTodosget the same treatmentTest plan
basecamp done <invalid-id>returns structured error with non-zero exitbasecamp done <valid-id>still succeeds normallybasecamp reopen <invalid-id>returns structured errorbin/cipasses