Conversation
e2e tests require bats-core but make tools didn't install it, unlike every other dev dependency.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR updates the developer tooling bootstrap so make tools also ensures bats is available, aligning the tools setup with the repo’s existing Bats-based e2e test suite requirements.
Changes:
- Add a
batspresence check tomake tools. - Auto-install
batsvia Homebrew (bats-core) or pacman (bats) when missing, with a fallback link to manual install instructions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make toolsnow installs bats-core (via brew or pacman) if missingmake toolsTest plan
make toolson a machine without bats — verify it gets installedmake test-e2eafter to confirm bats worksSummary by cubic
Update
make toolsto auto-installbats-core(viabreworpacman) if missing, so e2e tests run without manual setup. If neither is available, it exits with a helpful install link.Written for commit bdd70c5. Summary will update on new commits.